From 2fb807391a7e45e464742cb0aa15c174a69209df Mon Sep 17 00:00:00 2001 From: firewave Date: Wed, 18 Feb 2026 00:01:22 +0100 Subject: [PATCH] enabled and fixed `unassignedVariable` Cppcheck warnings --- scripts/run_cppcheck.sh | 2 +- xrdp/xrdp_encoder.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/run_cppcheck.sh b/scripts/run_cppcheck.sh index 738a9b65..16d32135 100755 --- a/scripts/run_cppcheck.sh +++ b/scripts/run_cppcheck.sh @@ -87,7 +87,7 @@ if [ -z "$CPPCHECK_FLAGS" ]; then --enable=warning,missingInclude,style --disable=portability --disable=performance --error-exitcode=1 \ -i third_party \ -i vrplayer \ - --suppress=constParameterCallback --suppress=variableScope --suppress=constParameterPointer --suppress=constVariablePointer --suppress=duplicateCondition --suppress=redundantAssignment --suppress=knownConditionTrueFalse --suppress=unreadVariable --suppress=constParameter --suppress=constVariable --suppress=shadowFunction --suppress=unusedStructMember --suppress=duplicateExpression --suppress=unsignedLessThanZero --suppress=shadowVariable --suppress=unreachableCode --suppress=noExplicitConstructor --suppress=constParameterReference --suppress=functionStatic --suppress=shadowArgument --suppress=truncLongCastAssignment --suppress=cstyleCast --suppress=constVariableReference --suppress=unassignedVariable --suppress=badBitmaskCheck \ + --suppress=constParameterCallback --suppress=variableScope --suppress=constParameterPointer --suppress=constVariablePointer --suppress=duplicateCondition --suppress=redundantAssignment --suppress=knownConditionTrueFalse --suppress=unreadVariable --suppress=constParameter --suppress=constVariable --suppress=shadowFunction --suppress=unusedStructMember --suppress=duplicateExpression --suppress=unsignedLessThanZero --suppress=shadowVariable --suppress=unreachableCode --suppress=noExplicitConstructor --suppress=constParameterReference --suppress=functionStatic --suppress=shadowArgument --suppress=truncLongCastAssignment --suppress=cstyleCast --suppress=constVariableReference --suppress=badBitmaskCheck \ --suppress=missingIncludeSystem \ --suppress=uninitMemberVar:ulalaca/ulalaca.cpp \ --suppress=dangerousTypeCast:ulalaca/XrdpStream.template.cpp \ diff --git a/xrdp/xrdp_encoder.c b/xrdp/xrdp_encoder.c index 19eb75e6..d6c5a49b 100644 --- a/xrdp/xrdp_encoder.c +++ b/xrdp/xrdp_encoder.c @@ -375,9 +375,10 @@ xrdp_encoder_create(struct xrdp_mm *mm) void xrdp_encoder_delete(struct xrdp_encoder *self) { +#if defined(XRDP_RFXCODEC) || defined(XRDP_X264) || defined(XRDP_OPENH264) int index; +#endif - (void)index; LOG_DEVEL(LOG_LEVEL_INFO, "xrdp_encoder_delete:"); if (self == 0)