From 6088ba3f3b4e65d1bbfee4e003374aad0b38ce95 Mon Sep 17 00:00:00 2001 From: matt335672 <30179339+matt335672@users.noreply.github.com> Date: Wed, 5 Feb 2025 10:14:18 +0000 Subject: [PATCH] Address offline Coverity issue This Coverity issue was encountered in a private build, but does not appear to be in the Github CI build. Coverity is suspecting a copy-paste betweem these lines in sound.c:- 1838: xstream_copyin(s, &g_stream_inp->data[g_stream_inp->size - g_bytes_in_stream], i); 1844: xstream_copyin(s, &g_stream_inp->data[g_stream_inp->size - g_bytes_in_stream], g_bytes_in_stream); An inspection of the code shows this to bre a false positive --- sesman/chansrv/sound.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sesman/chansrv/sound.c b/sesman/chansrv/sound.c index ba3685ae..4fd1b35a 100644 --- a/sesman/chansrv/sound.c +++ b/sesman/chansrv/sound.c @@ -1835,6 +1835,7 @@ sound_sndsrvr_source_data_in(struct trans *trans) if (i < g_bytes_in_stream) { + //coverity[COPY_PASTE_ERROR:FALSE] xstream_copyin(s, &g_stream_inp->data[g_stream_inp->size - g_bytes_in_stream], i); bytes_read += i; g_bytes_in_stream -= i;