github/xrdp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3637 from AlexTMjugador/fix/unitialized-pam-tty-item

Browse Source 
Fix `PAM_TTY` item being set to uninitialized data in PAM userpass lib
This commit is contained in:
matt335672
2025-10-15 16:06:11 +01:00
committed by GitHub
parent c83da5c6b6 0ae672d200
commit a14443119f
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sesman/libsesman/verify_user_pam_userpass.c
+1 -2
View File
@@ -69,7 +69,6 @@ common_pam_login(struct auth_info *auth_info,
int need_pam_authenticate) int need_pam_authenticate)
{ {
int perror; int perror;
char service_name[256];
perror = pam_start(SERVICE, auth_info->userpass.user, perror = pam_start(SERVICE, auth_info->userpass.user,
&(auth_info->pamc), &(auth_info->ph)); &(auth_info->pamc), &(auth_info->ph));
@@ -92,7 +91,7 @@ common_pam_login(struct auth_info *auth_info,
} }
} }
perror = pam_set_item(auth_info->ph, PAM_TTY, service_name); perror = pam_set_item(auth_info->ph, PAM_TTY, SERVICE);
if (perror != PAM_SUCCESS) if (perror != PAM_SUCCESS)
{ {
LOG(LOG_LEVEL_ERROR, "pam_set_item(PAM_TTY) failed: %s", LOG(LOG_LEVEL_ERROR, "pam_set_item(PAM_TTY) failed: %s",