github/xrdp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sesexec: Fix CVE-2026-42218 regression

Browse Source 
cppcheck has picked up on the use of an unitialised variable in
the implementation of the fix for CVE-2026-42218
This commit is contained in:
matt335672
2026-06-17 09:54:06 +01:00
parent 6cb996e355
commit d4d20fc82d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sesman/sesexec/login_info.c
+2 -2
View File
@@ -108,7 +108,7 @@ authenticate_and_authorize_connection(const char *supplied_username,
/* Call the auth stack anyway. On some systems (e.g. linux-pam), /* Call the auth stack anyway. On some systems (e.g. linux-pam),
* a fixed delay is built in to the stack for an unsuccessful * a fixed delay is built in to the stack for an unsuccessful
* login, and this delay may exceed FAILED_LOGIN_CONSTANT_TIME */ * login, and this delay may exceed FAILED_LOGIN_CONSTANT_TIME */
auth_end(auth_userpass(username, password, ip_addr, NULL)); auth_end(auth_userpass(supplied_username, password, ip_addr, NULL));
} }
else if (g_getuser_info_by_uid(uid, else if (g_getuser_info_by_uid(uid,
&username, &username,
@@ -116,7 +116,7 @@ authenticate_and_authorize_connection(const char *supplied_username,
{ {
LOG(LOG_LEVEL_ERROR, "Can't reverse lookup UID %d", uid); LOG(LOG_LEVEL_ERROR, "Can't reverse lookup UID %d", uid);
status = E_SCP_LOGIN_NOT_AUTHENTICATED; status = E_SCP_LOGIN_NOT_AUTHENTICATED;
auth_end(auth_userpass(username, password, ip_addr, NULL)); auth_end(auth_userpass(supplied_username, password, ip_addr, NULL));
} }
else else
{ {