63 Commits

Author SHA1 Message Date
firewave 67c11f0443 mitigated -Wdocumentation and -Wdocumentation-unknown-command Clang compiler warnings 2025-11-04 13:40:33 +01:00
matt335672 6ba1503b6a Disable vmconnect mode for non-vsock connections 2025-05-08 11:51:32 +01:00
gpotter2 09e1173259 Apply suggestions
Co-Authored-By: matt335672 <30179339+matt335672@users.noreply.github.com>
2025-05-08 06:45:05 +02:00
gpotter2 f0bae0050c vmconnect mode: support all security modes when used in Hyper-V environment 2025-05-06 21:49:56 +02:00
matt335672 463e500f77 Security improvements
1) In FIPS mode, Classic RDP security is not allowed at all.
2) In FIPS mode xrdp-keygen creates an empty file
3) Documentation wording improved around the security_level setting
4) Logging improved around the security negotiation
5) Warnings now generated if Classic RDP security is negotiated
2025-05-06 11:30:36 +01:00
matt335672 ffe9ac9122 Coverity CID 468130
g_bitmask_to_str() can return < 0 on error. This is not adequately
catered for.
2025-04-22 14:51:26 +01:00
Nexarian d23f7328f8 Minor logging fixes in xrdp_iso.c
Two logging errors found while working in these files.
2022-02-15 08:29:42 -05:00
matt335672 62ca216d4d Improve security level logging at ISO layer 2021-09-03 12:30:02 +01:00
aquesnel 0ec471b02d Add detailed logging to libxrdp (#1742)
* Added s_rem(s) for getting the remaining bytes in a stream
* Added s_rem_out() macro
* Fixed 15bpp pointer error checking
* Combined the 512 and 2048 bit certificate sending  code paths
* Other detailed comments and logging added following MS-RDPBCGR
2021-02-04 10:11:54 +00:00
Alexandre Quesnel a82ee03d4d Changing LOG_DEVEL to LOG to avoid silent failures. 2020-12-05 19:22:50 +00:00
Alexandre Quesnel 2d6d249f76 Fixing code formatting with astyle 2020-11-30 05:04:11 +00:00
Alexandre Quesnel 51905d765a Migrating logging to LOG() and LOG_DEVEL() in libxrdp/* 2020-11-30 05:04:10 +00:00
matt335672 da3114007c Address possible memory out-of-bounds accesses 2020-04-15 09:57:05 +01:00
matt335672 6f881d47d3 Rationalise ms- constants
Constants from MS documents (MS-RDPBCGR etc) moved out of
common/xrdp_constants.h into includes named after the documents.

Similar includes moved from sesman/chansrv to the common area.
2020-01-06 15:46:37 +00:00
Koichiro IWAO 4f7969b562 Check certificate/privkey readability not existence
to fail RDP security negotiation if certificate/privkey is not readable
2017-06-12 16:57:04 +09:00
Pavel Roskin 6ed4c969f4 Eliminate APP_CC and DEFAULT_CC 2017-03-14 00:21:48 -07:00
Pavel Roskin b2d3dcf169 Include config_ac.h from all source files 2017-03-04 00:52:34 -08:00
Pavel Roskin d3c36b0376 Don't select SSL protocol if no keys, fall back to RDP for "hybrid"
If both the client and the server are configured to allow both RDP and
SSL connections, the server is free to choose RDP in absense of the SSL
keys.
2016-11-28 00:18:33 -08:00
Pavel Roskin d73f20499e Log the result of the security level negotiation 2016-11-28 00:18:16 -08:00
Pavel Roskin ca9cbcafc8 Typo fixes 2016-05-04 23:33:30 -07:00
Jay Sorg 87208db090 fix warnings 2016-04-09 22:10:12 -07:00
Jay Sorg b56aa9832e work on main loop changes 2015-07-05 23:14:46 -07:00
speidy 9fb02e381d libxrdp: xrdp_iso: changed logs, some fixes in security layer
negotiation.
2015-06-04 16:48:41 +03:00
Jay Sorg 69a551cdf7 libxrdp: indent, no logic change 2014-12-16 12:20:57 -08:00
speidy bf622c46a6 libxrdp: security layer, error handling 2014-12-13 16:36:23 +02:00
speidy fb306e624e libxrdp: changes for security layer negotiation,
security_layer=negotiate is working now
2014-12-13 16:24:07 +02:00
Idan Freiberg 16929efb05 Merge branch 'devel' of https://github.com/neutrinolabs/xrdp into
devel

Conflicts:
	libxrdp/xrdp_sec.c
2014-07-23 16:44:59 +03:00
Idan Freiberg afdf638c7b libxrdp, common: work on TLS mode 2014-07-23 15:31:45 +03:00
Laxmikant Rashinkar 3bb31876e7 coverity: fixed resolution leak issues 2014-07-19 11:56:00 -07:00
Idan Freiberg 7ab1d887ae libxrdp: work on TLS support 2014-07-17 14:29:23 +03:00
Idan Freiberg 5fcf6beffa libxrdp: enforce server security layer when rdpNegData is not exists 2014-07-14 15:33:41 +03:00
speidy 194ad781ba libxrdp: another len fix 2014-07-12 07:19:02 +03:00
speidy 13a376ae38 libxrdp: fix off by one length indicator issue 2014-07-12 02:07:33 +03:00
Idan Freiberg 9795ce010a libxrdp: changes in rdp security layer negotiation 2014-07-10 15:40:16 +03:00
speidy ba6c71fd37 libxrdp: iso: fixed a validation check in RDP_NEG_REQ (CORRELATION_INFO_PRESENT flag is sent by mac itap client by default from now) 2014-07-02 00:57:38 +03:00
Jay Sorg 932d785deb fast path changes, iso never reads now 2014-03-04 18:11:55 -08:00
Jay Sorg e9e14f22f9 started work on fastpath, restructure PDU in 2014-02-25 20:47:34 -08:00
Jay Sorg a31234539a libxrdp: ISO_PDU_CR len fix 2013-10-09 23:04:03 -07:00
Jay Sorg 5adbf2d32b libxrdp: some ISO_PDU_CR changes 2013-10-09 18:23:21 -07:00
Jay Sorg 2df63787ca libxrdp: some ISO_PDU_CR changes 2013-10-09 16:33:13 -07:00
Jay Sorg 086481395c Merge branch 'multimon' of git://github.com/speidy/xrdp into speidy-multimon
Conflicts:
	common/xrdp_client_info.h
	libxrdp/xrdp_iso.c
	libxrdp/xrdp_sec.c
2013-10-09 14:15:50 -07:00
speidy a4d2917a0a libxrdp: iso_send_rdpnegrdp fix + notes. 2013-10-09 23:06:45 +03:00
speidy c2e7da84d4 libxrdp: add clientRequestedProtocol only when RDPNEGDATA occurs. 2013-10-09 23:00:05 +03:00
speidy a8ab4cb5d1 libxrdp: work on RDP negotiation, add legacy non-nego support. 2013-10-09 22:41:24 +03:00
speidy da62badee5 libxrdp: work on RDP negotiation, add clientRequestedProtocol to MCS
response. (hardcoded values - temporarily)
2013-10-01 08:35:27 +03:00
speidy 24e4b8c937 libxrdp: work on RDP negotiation part 2013-09-25 18:07:20 +03:00
speidy 9bf2d0dc60 libxrdp: work on RDP negotiation, not working yet. 2013-09-25 16:54:45 +03:00
speidy 2b0524ad7e libxrdp: work on RDP negotiation 2013-09-20 00:06:04 +03:00
Jay Sorg 39ed446e15 VUL: fix some possible buffer overruns 2013-09-10 16:00:30 -07:00
speidy 944f266a82 libxrdp: work on multi-mon, x.224 confirm packet 2013-07-15 22:45:40 +03:00