4417646cda
waitforx: remove unneded header
...
The sys/signal.h is essentially a redirect to signal.h, without further
logic. However when using musl libc, a warning (which is treated as an error)
is also emitted about this:
| /usr/include/sys/signal.h:1:2: error: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Werror=cpp]
| 1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>
Remove sys/signal.h header to solve the problem - the signal.h header is already
included in this file.
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com >
2025-11-25 15:43:38 +01:00
ec604732fd
resize_queue: Create before drdynvc is available
...
If drdynvc is not available for some reason, the resize queue is not
created. This results in a coredump if the display server requests a
resize.
2025-11-24 11:47:27 +00:00
dbce657177
Merge pull request #3636 from matt335672/optimize_resize_queue
...
resize queue: drop unactioned client requests
2025-11-24 10:17:45 +00:00
834ab918f7
resize queue: Drop unprocessed client requests
...
If we're adding a new client request to the queue, and the item
immediately before it is also a client request which is not yet actioned,
we can remove the previous item, as it has been superceded.
2025-11-21 12:33:38 +00:00
6c90bc2493
Delay processing of the resize queue
...
Processing of the resize queue is delayed until we've connected to a
session, as the login screen is currently unable to cope with these
requests.
2025-11-21 12:33:38 +00:00
c31c499372
os_calls: Add NULL_WAIT_OBJ
...
The wait_obj calls (mostly) ignore objects with a value of zero. This
is codified, so that user code can explicitly make use of this.
2025-11-21 12:33:38 +00:00
64a7c13a77
Tag all resize_queue items with a source
...
Add a source tag for all the resize_queue items, so we can make
some decisions about queue optimisations.
2025-11-21 12:33:38 +00:00
30c497eae4
Merge pull request #3671 from shua21/xrdp
...
do not change port when not using sesman
2025-11-19 15:32:53 +00:00
ba36dacf95
do not change xvnc port when not using sesman
2025-11-19 22:51:42 +09:00
e7611866ad
Merge pull request #3669 from matt335672/add_slovenian_kbd
...
Add slovenian keyboard
2025-11-17 09:46:07 +00:00
2be66424d2
Add Slovenian keyboard defs for xorgxrdp
2025-11-14 11:12:50 +00:00
0aff9c31b2
Add Slovenian (si) keyboard definition
2025-11-14 11:08:36 +00:00
d63fedf239
Merge pull request #3663 from matt335672/clarify_xorg_path
...
sesman.ini: Update well-known paths for Xorg
2025-11-07 13:42:57 +00:00
4b87cfc08f
Merge pull request #2831 from firewave/wdoc
...
mitigated `-Wdocumentation` and `-Wdocumentation-unknown-command` Clang compiler warnings
2025-11-06 11:21:40 +00:00
0bf09425c5
Merge pull request #3657 from firewave/missinclude
...
enabled and fixed `missingInclude` Cppcheck warnings
2025-11-06 11:20:17 +00:00
0d73c2e9fe
Merge pull request #3660 from firewave/wextra
...
configure.ac: enabled `-Wextra` compiler warning
2025-11-06 11:17:54 +00:00
5abd51b675
Code quality: Fix expansion-to-defined warning
...
Fixes a gcc compiler warning regarding a potentially unportable
use of 'defined()' in a macro
2025-11-05 13:51:49 +01:00
71a629d509
Code quality: Allow for zero initializers
2025-11-05 13:51:49 +01:00
6b816d0c64
common/list.c: fixed -Wcalloc-transposed-args GCC warning
...
```
/home/user/CLionProjects/xrdp/common/list.c: In function ‘list_create_sized’:
/home/user/CLionProjects/xrdp/common/list.c:50:41: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
50 | self = (struct list *)calloc(sizeof(struct list), 1);
| ^~~~~~
/home/user/CLionProjects/xrdp/common/list.c:50:41: note: earlier argument should specify number of elements, later size of each element
```
2025-11-05 13:51:49 +01:00
b4cf498144
fixed -Wold-style-declaration compiler warnings
...
Example:
```
fontutils/fv1.c:36:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration]
36 | const static char FV1_SIGNATURE[] = {'F', 'N', 'T', '1'};
| ^~~~~
```
2025-11-05 13:51:49 +01:00
b2fed3e8fc
configure.ac: enabled -Wextra compiler warning
2025-11-05 13:51:49 +01:00
0d3122d82f
sesman.ini: Update well-known paths for Xorg
...
Include explicit references for AlmaLinux and Rocky, and remove
references to CentOS to better suit current audiences.
2025-11-05 11:00:39 +00:00
04901714f8
exclude vrplayer from Cppcheck for now because it requires Qt headers to be generated
2025-11-04 13:47:47 +01:00
01c60f9ba4
added missing include paths for Cppcheck
2025-11-04 13:41:26 +01:00
d580c8d339
adjusted some includes
2025-11-04 13:41:26 +01:00
e678de9360
enabled missingInclude Cppcheck warnings
2025-11-04 13:41:26 +01:00
7583e192e7
configure.ac: treat freetype2 include folder as a system one
2025-11-04 13:40:33 +01:00
67c11f0443
mitigated -Wdocumentation and -Wdocumentation-unknown-command Clang compiler warnings
2025-11-04 13:40:33 +01:00
9d46ae763d
Merge pull request #3658 from matt335672/remove_xrdp_process_casts
...
Code quality: Remove 'struct xrdp_process *' casts
2025-11-04 09:19:53 +00:00
9e1a8d78c2
Merge pull request #3572 from matt335672/cppcheck_2_18
...
Update to cppcheck 2.18.3
2025-11-03 10:39:57 +00:00
c646002779
Code quality: Remove 'struct xrdp_process *' casts
...
The first argument to libxrdp_init() is a intptr_t / tbus value. This
represents the xrdp instance which is using the library, but this value
is always a 'struct xrdp_process' pointer.
This PR replaces the intptr_t with an incomplete type declaration at
the interface between xrdp and libxrdp.
The original intention was probably to provide some separation from
xrdp and the libxrdp code, but in practice this has turned out not to be
useful.
2025-11-03 10:34:42 +00:00
b8e7c6eeb2
cppcheck: Minor bump to 2.18.3
2025-10-31 20:30:24 +00:00
5853a781b9
Update to cppcheck 2.18.0
2025-10-31 20:30:24 +00:00
854d9489df
Merge pull request #3655 from matt335672/coverity_fix
...
Coverity: Fix CHECKED_RETURN warning
2025-10-31 14:38:04 +00:00
d95893a8c3
Coverity: Fix CHECKED_RETURN warning
2025-10-31 14:20:02 +00:00
f387522c83
Merge pull request #3653 from matt335672/fix_bsd_confusion
...
configure: Remove confusion between bsd and enable_bsd symbols
2025-10-30 15:48:55 +00:00
e329a34b58
configure: Remove confusion between bsd and enable_bsd symbols
2025-10-30 11:51:16 +00:00
0f17ac3b87
Merge pull request #3642 from matt335672/restricted_shell
...
session management: Allow for restricted shells
2025-10-28 10:13:00 +00:00
90a027851a
PassShellAsEnv: Update docs
2025-10-28 10:04:03 +00:00
6b6edca8ca
session management: Allow for restricted shells
...
Allows the AlternateShell specified by the user in the TS_INFO_PACKET
to be passed to startwm.sh as an environment variable.
2025-10-28 10:04:03 +00:00
23e12403e3
Merge pull request #3647 from jsorg71/daemon_pid
...
do not delete pid file unless this current pid matches the daemon pid
2025-10-27 11:22:29 -07:00
1cecd786f7
do not delete pid file unless this current pid matches the daemon pid
2025-10-27 10:48:14 -07:00
1efcad26f8
Merge pull request #3648 from jsorg71/jpeg_frame_ack
...
pass frame id back to main thread in jpeg encode
2025-10-27 10:44:34 -07:00
74c2cf31d2
pass frame id back to main thread in jpeg encode
2025-10-27 09:48:33 -07:00
5d8901d5df
Merge pull request #3613 from matt335672/use_fastpath_for_login_screen
...
Use fastpath for login screen
2025-10-27 11:40:52 +00:00
bafd7eb2df
login screen: Use fastpath updates if available
...
If output fastpath is enabled, use TS_FP_UPDATE_BITMAP rather than
TS_UPDATE_BITMAP for the login screen.
2025-10-27 10:47:19 +00:00
1c1a5ebe0f
Merge pull request #3600 from matt335672/rfx_segv
...
Ignore Frame ACKs when the encoder is deleted
2025-10-21 12:02:27 +01:00
43a0c91aa2
Merge pull request #3632 from matt335672/add_fuse_root_report_max_free
...
Add FuseRootReportMaxFree option
2025-10-15 16:20:58 +01:00
a14443119f
Merge pull request #3637 from AlexTMjugador/fix/unitialized-pam-tty-item
...
Fix `PAM_TTY` item being set to uninitialized data in PAM userpass lib
2025-10-15 16:06:11 +01:00
0ae672d200
Fix PAM_TTY item being set to uninitialized data in PAM userpass lib
...
The local variable it referenced was never initialized before use. I
replaced it with a reference to the seemingly intended `SERVICE`
preprocessor constant, which is also used in the `pam_start` call
slightly above.
2025-10-13 21:18:13 +02:00
Gyorgy Sarvari