Commit Graph

5337 Commits

Author SHA1 Message Date
matt335672 94c0024c3b passwd_unix: Change salt if password is changed 2026-02-20 16:02:05 +01:00
firewave 416aa53157 enabled cppcheck portability checks 2026-02-20 16:02:05 +01:00
matt335672 ce501dff70 Merge pull request #3732 from firewave/cppcheck-style
enabled and fixed some cppcheck `style` checks
2026-02-20 13:53:57 +00:00
matt335672 588fac89f2 Merge pull request #3734 from tsz8899/tsz/coverity-fix-recent-regressions-0x18
coverity fix recent regressions
2026-02-18 17:32:24 +00:00
tsz8899 d5b3b6a20a xrdp_mm: apply firewave suggestion in setup_mod2 2026-02-18 23:47:16 +08:00
firewave 2fb807391a enabled and fixed unassignedVariable Cppcheck warnings 2026-02-18 11:26:45 +01:00
tsz8899 f2b1b21b6c Coverity: fix recent regressions 0x18 error 2026-02-18 13:25:23 +08:00
matt335672 ea7cea2a97 Coverity: fix recent regressions 2026-02-18 13:25:23 +08:00
firewave 077dbbcba9 enabled some cppcheck style checks 2026-02-17 19:01:19 +01:00
matt335672 bbd950d552 Merge pull request #3726 from matt335672/rfb_auth_fixes
RFB authentication: Undefined behaviour fix
2026-02-12 12:20:09 +00:00
matt335672 8b252fb462 VNC auth: Do not try to create empty file
When using UDS mode for VNC, the following error has been reported:

[WARN ] Cannot write VNC password hash to file (null): Bad address

This prevents an attempt to create a file with a NULL name.
2026-02-12 11:50:09 +00:00
matt335672 7fcec1e6da Harden env_check_password_file()
env_check_password_file() does not check its parameters are non-NULL.
This commit simply adds those checks.
2026-02-12 11:48:54 +00:00
matt335672 b3ab2c28d8 Merge pull request #3695 from akarl10/user-shell-environment-fix
User shell environment fix
2026-02-12 11:26:52 +00:00
matt335672 eb4514210d Merge pull request #3719 from tsz8899/fix/segfault-at-0x18-robustness
Fix: Segfault at 0x18 due to race condition between UI destruction and event dispatching
2026-02-06 11:54:11 +00:00
tsz8899 8a393c9d0d Fix: Segfault at 0x18 - Upstream Review V3 (Final)
- Removes all redundant NULL checks as per latest feedback.
- Retains C99 inline variable declarations.
- Finalizes local variable snapshotting for race condition safety.
2026-02-06 19:41:11 +08:00
jsorg71 4d9dde8ea0 Merge pull request #3714 from jsorg71/move_cursor
add move_cursor
2026-02-02 21:15:03 -08:00
Jay Sorg 5637721f5a add move_cursor 2026-01-30 18:54:57 -08:00
metalefty 488c8c7d4d Merge commit from fork
CVE-2025-68670
2026-01-27 18:17:29 +09:00
matt335672 661fe2eb0e Merge pull request #3686 from lcniel/add_port_discriminator
Allow sessions to be distinguished based on XRDP instance_name configuration by using new policy
2026-01-26 09:47:02 +00:00
Leonard Nielsen 0edde4c090 Introduce instance_name field into xrdp.ini and xrdp-sesrun, along with
the N policy in sesman.ini, allowing xrdp sessions to be tagged with an
instance name to enable persistent association with a specific
xrdp instance, to allow experiences where users reconnect to specific
sessions based on e.g. the xrdp listening port used.
2026-01-20 12:03:15 +01:00
akarl10 c1ed8b8eb6 [sesexec] pass_shell_as_env only if user sets a shell
set environment variable only if the user actually requests a specific
shell.
2026-01-18 10:27:47 +01:00
metalefty c7b83c47b3 Merge pull request #3700 from matt335672/cppcheck_2_19
cppcheck: Bump version to 2.19.1
2026-01-15 20:35:02 +09:00
matt335672 311a88f1fc cppcheck: Bump version to 2.19.1 2026-01-13 10:31:38 +00:00
matt335672 1cab2d91da Merge pull request #3694 from matt335672/coverity_fix
Coverity: Fix TAINTED_SCALAR warning
2025-12-29 11:24:02 +00:00
matt335672 28c1cbea97 Coverity: Fix TAINTED_SCALAR warning 2025-12-29 11:02:21 +00:00
matt335672 846a32a6b4 Merge pull request #3640 from matt335672/xrdpapi_connect_status
xrdpapi: Add a way to monitor connect/disconnect events
2025-12-28 11:39:07 +00:00
matt335672 9c5ee210cd xrdpapi: Fix simple test regression 2025-12-28 11:34:06 +00:00
matt335672 756d415bbc strncpy: Replace some instances
Instances of g_strncpy() in xrdp_wm_parse_domain_information() are
replaced with strlcpy()
2025-12-24 16:57:53 +00:00
matt335672 dd4b56c987 CVE-2025-68670: Buffer overflow parsing domain
A potential overflow in xrdp_wm_parse_domain_information() is
addressed
2025-12-24 16:56:32 +00:00
matt335672 6234ccd2f4 xrdpapi: Add demo program for session events 2025-12-15 11:29:16 +00:00
matt335672 6a5d858dce xrdpapi: Add a way to get client connect status
Functions are added to xrdpapi to allows the connection status
to be determimed. These functions are modelled on the Windows API
functions, but are not compatible with them. In particular, the error
handling is different.

A way for an application to receive events is also provided. At present,
only connect/disconnected events are implemented.
2025-12-15 11:26:21 +00:00
matt335672 d90b9d9316 xrdpapi: Fix memory leak in WTSVirtualChannelOpenEx() 2025-12-15 11:22:54 +00:00
matt335672 259dc937bf Merge pull request #3683 from matt335672/fix_race_g_create_path
Fix Possible race condition in g_create_path()
2025-12-03 11:07:37 +00:00
matt335672 092e430512 Fix Psssible race condition in g_create_path()
(cherry picked from commit 2e597120443c7dcb0b32f6078999098a364f9543)
2025-12-03 11:00:28 +00:00
matt335672 0c73ea5328 Merge pull request #3684 from matt335672/devel
CI: Bump FreeBSD to 14.3
2025-12-03 10:55:02 +00:00
matt335672 e14dd6de77 CI: Bump FreeBSD to 14.3 2025-12-03 10:40:47 +00:00
matt335672 849001956e Merge pull request #3677 from matt335672/init_resize_queue_early
resize_queue: Create before drdynvc is available
2025-12-01 13:58:35 +00:00
matt335672 8702bfe43b Merge pull request #3678 from OldManYellsAtCloud/devel
waitforx: remove unneded header
2025-11-26 09:33:25 +00:00
Gyorgy Sarvari 4417646cda waitforx: remove unneded header
The sys/signal.h is essentially a redirect to signal.h, without further
logic. However when using musl libc, a warning (which is treated as an error)
is also emitted about this:

| /usr/include/sys/signal.h:1:2: error: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Werror=cpp]
|     1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>

Remove sys/signal.h header to solve the problem - the signal.h header is already
included in this file.

Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
2025-11-25 15:43:38 +01:00
matt335672 ec604732fd resize_queue: Create before drdynvc is available
If drdynvc is not available for some reason, the resize queue is not
created. This results in a coredump if the display server requests a
resize.
2025-11-24 11:47:27 +00:00
matt335672 dbce657177 Merge pull request #3636 from matt335672/optimize_resize_queue
resize queue: drop unactioned client requests
2025-11-24 10:17:45 +00:00
matt335672 834ab918f7 resize queue: Drop unprocessed client requests
If we're adding a new client request to the queue, and the item
immediately before it is also a client request which is not yet actioned,
we can remove the previous item, as it has been superceded.
2025-11-21 12:33:38 +00:00
matt335672 6c90bc2493 Delay processing of the resize queue
Processing of the resize queue is delayed until we've connected to a
session, as the login screen is currently unable to cope with these
requests.
2025-11-21 12:33:38 +00:00
matt335672 c31c499372 os_calls: Add NULL_WAIT_OBJ
The wait_obj calls (mostly) ignore objects with a value of zero. This
is codified, so that user code can explicitly make use of this.
2025-11-21 12:33:38 +00:00
matt335672 64a7c13a77 Tag all resize_queue items with a source
Add a source tag for all the resize_queue items, so we can make
some decisions about queue optimisations.
2025-11-21 12:33:38 +00:00
matt335672 30c497eae4 Merge pull request #3671 from shua21/xrdp
do not change port when not using sesman
2025-11-19 15:32:53 +00:00
shua21 ba36dacf95 do not change xvnc port when not using sesman 2025-11-19 22:51:42 +09:00
matt335672 e7611866ad Merge pull request #3669 from matt335672/add_slovenian_kbd
Add slovenian keyboard
2025-11-17 09:46:07 +00:00
matt335672 2be66424d2 Add Slovenian keyboard defs for xorgxrdp 2025-11-14 11:12:50 +00:00
matt335672 0aff9c31b2 Add Slovenian (si) keyboard definition 2025-11-14 11:08:36 +00:00