Coverity CID 468156

Coverity is complaining about 32-bits being truncated to 16-bits. Make the data conversion to unsigned short explicit.
2025-04-17 14:44:38 +01:00
parent c6fb510892
commit d30f5fe22b
1 changed files with 5 additions and 9 deletions
@@ -367,19 +367,15 @@ scancode_to_index(unsigned short scancode)
 unsigned short
 scancode_from_index(int index)
 {
-    index &= 0xff;
-    unsigned short result;
-    if (index == SCANCODE_INDEX_PAUSE_KEY)
+    unsigned short result = index & 0xff;
+
+    if (result == SCANCODE_INDEX_PAUSE_KEY)
    {
        result = SCANCODE_PAUSE_KEY;
    }
-    else if (index < 0x80)
+    else if ((result & 0x80) != 0)
    {
-        result = index;
-    }
-    else
-    {
-        result = (index & 0x7f) | 0x100;
+        result ^= 0x180; // Clear bit 7, set bit 8
    }
    return result;
 }