matt335672
2be66424d2
Add Slovenian keyboard defs for xorgxrdp
2025-11-14 11:12:50 +00:00
matt335672
0aff9c31b2
Add Slovenian (si) keyboard definition
2025-11-14 11:08:36 +00:00
matt335672
d63fedf239
Merge pull request #3663 from matt335672/clarify_xorg_path
...
sesman.ini: Update well-known paths for Xorg
2025-11-07 13:42:57 +00:00
matt335672
4b87cfc08f
Merge pull request #2831 from firewave/wdoc
...
mitigated `-Wdocumentation` and `-Wdocumentation-unknown-command` Clang compiler warnings
2025-11-06 11:21:40 +00:00
matt335672
0bf09425c5
Merge pull request #3657 from firewave/missinclude
...
enabled and fixed `missingInclude` Cppcheck warnings
2025-11-06 11:20:17 +00:00
matt335672
0d73c2e9fe
Merge pull request #3660 from firewave/wextra
...
configure.ac: enabled `-Wextra` compiler warning
2025-11-06 11:17:54 +00:00
matt335672
5abd51b675
Code quality: Fix expansion-to-defined warning
...
Fixes a gcc compiler warning regarding a potentially unportable
use of 'defined()' in a macro
2025-11-05 13:51:49 +01:00
matt335672
71a629d509
Code quality: Allow for zero initializers
2025-11-05 13:51:49 +01:00
firewave
6b816d0c64
common/list.c: fixed -Wcalloc-transposed-args GCC warning
...
```
/home/user/CLionProjects/xrdp/common/list.c: In function ‘list_create_sized’:
/home/user/CLionProjects/xrdp/common/list.c:50:41: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
50 | self = (struct list *)calloc(sizeof(struct list), 1);
| ^~~~~~
/home/user/CLionProjects/xrdp/common/list.c:50:41: note: earlier argument should specify number of elements, later size of each element
```
2025-11-05 13:51:49 +01:00
firewave
b4cf498144
fixed -Wold-style-declaration compiler warnings
...
Example:
```
fontutils/fv1.c:36:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration]
36 | const static char FV1_SIGNATURE[] = {'F', 'N', 'T', '1'};
| ^~~~~
```
2025-11-05 13:51:49 +01:00
firewave
b2fed3e8fc
configure.ac: enabled -Wextra compiler warning
2025-11-05 13:51:49 +01:00
matt335672
0d3122d82f
sesman.ini: Update well-known paths for Xorg
...
Include explicit references for AlmaLinux and Rocky, and remove
references to CentOS to better suit current audiences.
2025-11-05 11:00:39 +00:00
firewave
04901714f8
exclude vrplayer from Cppcheck for now because it requires Qt headers to be generated
2025-11-04 13:47:47 +01:00
firewave
01c60f9ba4
added missing include paths for Cppcheck
2025-11-04 13:41:26 +01:00
firewave
d580c8d339
adjusted some includes
2025-11-04 13:41:26 +01:00
firewave
e678de9360
enabled missingInclude Cppcheck warnings
2025-11-04 13:41:26 +01:00
firewave
7583e192e7
configure.ac: treat freetype2 include folder as a system one
2025-11-04 13:40:33 +01:00
firewave
67c11f0443
mitigated -Wdocumentation and -Wdocumentation-unknown-command Clang compiler warnings
2025-11-04 13:40:33 +01:00
matt335672
9d46ae763d
Merge pull request #3658 from matt335672/remove_xrdp_process_casts
...
Code quality: Remove 'struct xrdp_process *' casts
2025-11-04 09:19:53 +00:00
matt335672
9e1a8d78c2
Merge pull request #3572 from matt335672/cppcheck_2_18
...
Update to cppcheck 2.18.3
2025-11-03 10:39:57 +00:00
matt335672
c646002779
Code quality: Remove 'struct xrdp_process *' casts
...
The first argument to libxrdp_init() is a intptr_t / tbus value. This
represents the xrdp instance which is using the library, but this value
is always a 'struct xrdp_process' pointer.
This PR replaces the intptr_t with an incomplete type declaration at
the interface between xrdp and libxrdp.
The original intention was probably to provide some separation from
xrdp and the libxrdp code, but in practice this has turned out not to be
useful.
2025-11-03 10:34:42 +00:00
matt335672
b8e7c6eeb2
cppcheck: Minor bump to 2.18.3
2025-10-31 20:30:24 +00:00
matt335672
5853a781b9
Update to cppcheck 2.18.0
2025-10-31 20:30:24 +00:00
matt335672
854d9489df
Merge pull request #3655 from matt335672/coverity_fix
...
Coverity: Fix CHECKED_RETURN warning
2025-10-31 14:38:04 +00:00
matt335672
d95893a8c3
Coverity: Fix CHECKED_RETURN warning
2025-10-31 14:20:02 +00:00
matt335672
f387522c83
Merge pull request #3653 from matt335672/fix_bsd_confusion
...
configure: Remove confusion between bsd and enable_bsd symbols
2025-10-30 15:48:55 +00:00
matt335672
e329a34b58
configure: Remove confusion between bsd and enable_bsd symbols
2025-10-30 11:51:16 +00:00
matt335672
0f17ac3b87
Merge pull request #3642 from matt335672/restricted_shell
...
session management: Allow for restricted shells
2025-10-28 10:13:00 +00:00
matt335672
90a027851a
PassShellAsEnv: Update docs
2025-10-28 10:04:03 +00:00
matt335672
6b6edca8ca
session management: Allow for restricted shells
...
Allows the AlternateShell specified by the user in the TS_INFO_PACKET
to be passed to startwm.sh as an environment variable.
2025-10-28 10:04:03 +00:00
jsorg71
23e12403e3
Merge pull request #3647 from jsorg71/daemon_pid
...
do not delete pid file unless this current pid matches the daemon pid
2025-10-27 11:22:29 -07:00
Jay Sorg
1cecd786f7
do not delete pid file unless this current pid matches the daemon pid
2025-10-27 10:48:14 -07:00
jsorg71
1efcad26f8
Merge pull request #3648 from jsorg71/jpeg_frame_ack
...
pass frame id back to main thread in jpeg encode
2025-10-27 10:44:34 -07:00
Jay Sorg
74c2cf31d2
pass frame id back to main thread in jpeg encode
2025-10-27 09:48:33 -07:00
matt335672
5d8901d5df
Merge pull request #3613 from matt335672/use_fastpath_for_login_screen
...
Use fastpath for login screen
2025-10-27 11:40:52 +00:00
matt335672
bafd7eb2df
login screen: Use fastpath updates if available
...
If output fastpath is enabled, use TS_FP_UPDATE_BITMAP rather than
TS_UPDATE_BITMAP for the login screen.
2025-10-27 10:47:19 +00:00
matt335672
1c1a5ebe0f
Merge pull request #3600 from matt335672/rfx_segv
...
Ignore Frame ACKs when the encoder is deleted
2025-10-21 12:02:27 +01:00
matt335672
43a0c91aa2
Merge pull request #3632 from matt335672/add_fuse_root_report_max_free
...
Add FuseRootReportMaxFree option
2025-10-15 16:20:58 +01:00
matt335672
a14443119f
Merge pull request #3637 from AlexTMjugador/fix/unitialized-pam-tty-item
...
Fix `PAM_TTY` item being set to uninitialized data in PAM userpass lib
2025-10-15 16:06:11 +01:00
Alejandro González
0ae672d200
Fix PAM_TTY item being set to uninitialized data in PAM userpass lib
...
The local variable it referenced was never initialized before use. I
replaced it with a reference to the seemingly intended `SERVICE`
preprocessor constant, which is also used in the `pam_start` call
slightly above.
2025-10-13 21:18:13 +02:00
matt335672
4d2c4ae8a5
Add FuseRootReportMaxFree option
...
Add an option to allow effectively disable file system space checks for
some file managers before copying files to remote drives.
This is a temporary solution. A better solution is to provide each
remote drive with its own mountpoint, so that the xrdp FUSE filesystem
becomes POSIX compliant.
2025-10-06 11:45:43 +01:00
matt335672
c83da5c6b6
Merge pull request #3616 from matt335672/sslkeylogfile
...
Allow TLS pre-master secrets to be recorded
2025-09-15 19:54:06 +01:00
matt335672
733990e9ed
Pre-master secret file: Change location for permission setting
...
Coverity scan picked up on the result on g_chmod_hex() not being
checked. This call has now been moved to the place where the file is
checked for writeability, as we only really need to make it when the
file is created.
2025-09-15 18:28:35 +01:00
matt335672
7f6899567b
Allow TLS pre-master secrets to be recorded
...
This allows for RDP sessions to be easily decrypted within Wireshark
2025-09-12 11:55:19 +01:00
matt335672
976a708599
Merge pull request #3612 from matt335672/code_improvements
...
Code improvements
2025-09-11 12:19:36 +01:00
matt335672
127a95e254
struct xrdp_session: Remove void * pointers
...
void * pointers in xrdp_session are replaced with pointers to
incomplete types. This allows us to remove a very large number of casts
related to these members in libxrdp.c
2025-09-09 15:16:32 +01:00
matt335672
0a13316e6a
ms-rdpbcgr.h: Rename incorrect slow path constants
...
Rename the defines from [MS-RDPBCGR] 2.2.9.1.1.3.1 to match
the documentation.
2025-09-09 15:15:46 +01:00
matt335672
2759680b8b
ms-rdpbcgr.h: Rename incorrect PDUTYPE2_ defines
...
Rename the defines from [MS-RDPBCGR] 2.2.8.1.1.1.2 to
match the documentation.
2025-09-09 15:14:28 +01:00
matt335672
557b580cb0
ms-rdpbcgr.h : Rename incorrect pointer update constants
...
Rename the defines from [MS-RDPBCGR] 2.2.9.1.1.4 and
2.2.9.1.1.4.3 to match the documentation.
2025-09-09 15:11:45 +01:00
matt335672
aade869fb7
Merge pull request #3607 from matt335672/fix_incorrect_control_pdu_vals
...
Fix more inconsistencies with [MS-RDPBCGR]
2025-09-06 10:04:35 +01:00