Liyi Meng
82b4eb6556
xrdp_input_enable() unconditionally reasserted XrdpIme as the global engine any time it wasn't already active, on the theory that ibus can silently revert to the user's original engine on its own. That's true, but the fix was too broad: it also fired whenever the user had manually switched the session's engine to something else entirely (e.g. libpinyin, to compose Chinese directly in the remote desktop rather than via the client's local IME), yanking control away mid-use. Confirmed happening live: a composition left pending in a client-side IME and then abandoned got auto-flushed by the OS well after the fact, silently reclaiming XrdpIme and interrupting an unrelated libpinyin session already in progress. Now only reclaims XrdpIme when the current engine is unset or matches the original one remembered before ever switching away from it (last_input_name) - the actual "ibus reverted on its own" case this existed for. Any other named engine is treated as a deliberate choice and left alone; the stale/deferred commit is dropped instead of hijacking whatever the user is currently doing. Also fixes a hang found while testing this: if xrdp_input_unicode_init() times out waiting for ibus_get_address() (daemon unreachable), it returned early without resetting ibus_thread_exited back to TRUE, even though it had just set it FALSE in anticipation of a thread that was never actually created. No thread means no broadcast ever comes, so any later xrdp_input_unicode_destroy() or re-init() call blocks on that condvar forever. Pre-existing in the private-loop rewrite, not introduced by this change - just surfaced by testing this one harder. Verified: 20 back-to-back init() calls on a healthy connection still take the fast path with no false failures; manually switching to a different engine and then sending a stale commit leaves that engine untouched and fails the commit; reverting to the original engine still correctly reasserts XrdpIme; 5 kill/restart cycles still show no thread leak; an 18-char rapid-fire send against a real focused GTK entry still lands every character in order. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
xrdp - an open source RDP server
Overview
xrdp provides a graphical login to remote machines using Microsoft Remote Desktop Protocol (RDP). xrdp accepts connections from a variety of RDP clients:
- FreeRDP
- rdesktop
- KRDC
- NeutrinoRDP
- Windows MSTSC (Microsoft Terminal Services Client, aka
mstsc.exe) - Microsoft Remote Desktop (found on Microsoft Store, which is distinct from MSTSC)
Many of these work on some or all of Windows, Mac OS, iOS, and/or Android.
RDP transport is encrypted using TLS by default.
Features
Remote Desktop Access
- Connect to a Linux desktop using RDP from anywhere (requires xorgxrdp Xorg module)
- Reconnect to an existing session
- Session resizing (both on-connect and on-the-fly)
- RDP/VNC proxy (connect to another RDP/VNC server via xrdp)
Access to Remote Resources
- Two-way clipboard transfer (text, bitmap, file)
- Audio redirection (requires to build additional modules)
- Microphone redirection (requires to build additional modules)
- Drive redirection (mount local client drives on remote machine)
Supported Platforms
xrdp primarily targets GNU/Linux operating system. x86 (including x86-64) and ARM processors are most mature architecture to run xrdp on. See also Platform Support Tier.
Some components such as xorgxrdp and RemoteFX codec have special optimization for x86 using SIMD instructions. So running xrdp on x86 processors will get fully accelerated experience.
Quick Start
Most Linux distributions should distribute the latest release of xrdp in their repository. You would need xrdp and xorgxrdp packages for the best experience. It is recommended that xrdp depends on xorgxrdp, so it should be sufficient to install xrdp. If xorgxrdp is not provided, use Xvnc server.
xrdp listens on 3389/tcp. Make sure your firewall accepts connection to 3389/tcp from where you want to access.
Ubuntu / Debian
apt install xrdp
Fedora, RHEL and derivatives
If you're not running Fedora, make sure to enable EPEL packages first.
dnf install epel-release
(All systems) Install xrdp with:-
dnf install xrdp
Compiling
See also https://github.com/neutrinolabs/xrdp/wiki#building-from-sources
Prerequisites
To compile xrdp from the packaged sources, you need basic build tools - a compiler (gcc or clang) and the make program. Additionally, you would need openssl-devel, pam-devel, libX11-devel, libXfixes-devel, libXrandr-devel. More additional software would be needed depending on your configuration.
To compile xrdp from a checked out git repository, you would additionally need autoconf, automake, libtool and pkg-config.
Get the source and build it
If compiling from the packaged source, unpack the tarball and change to the resulting directory.
If compiling from a checked out repository, please make sure you've got the submodules
cloned too (use git clone --recursive https://github.com/neutrinolabs/xrdp)
Then run following commands to compile and install xrdp:
./bootstrap
./configure
make
sudo make install
If you want to use audio redirection, you need to build and install additional pulseaudio modules. The build instructions can be found at wiki.
Directory Structure
xrdp
├── common ······ common code
├── docs ········ documentation
├── fontutils ··· font handling utilities
├── genkeymap ··· keymap generator
├── instfiles ··· installable data file
├── keygen ······ xrdp RSA key pair generator
├── libpainter ·· painter library
├── librfxcodec · RFX codec library
├── libxrdp ····· core RDP protocol implementation
├── m4 ·········· Autoconf macros
├── mc ·········· media center module
├── neutrinordp · RDP client module for proxying RDP connections using NeutrinoRDP
├── pkgconfig ··· pkg-config configuration
├── scripts ····· build scripts
├┬─ sesman ······ session manager for xrdp
|├── chansrv ···· channel server for xrdp
|├── libsesman ·· Code common to sesman and its related executables
|└── tools ······ session management tools for sys admins
├── tests ······· tests for the code
├┬─ tools ······· tools
|└┬─ devel ······ development tools
| ├── gtcp_proxy GTK app that forwards TCP connections to a remote host
| └── tcp_proxy · CLI app that forwards TCP connections to a remote host
├── vnc ········· VNC client module for xrdp
├── vrplayer ···· QT player redirecting video/audio to clients over xrdpvr channel
├── xrdp ········ main server code
├── xrdpapi ····· virtual channel API
├── xrdpvr ······ API for playing media over RDP
└── xup ········· xorgxrdp client module